Conversation
- Bump version in package.json from 1.3.1 to 1.3.3. - Add new build scripts for packaging all versions and releasing. - Introduce debug mode instructions in README.md for better troubleshooting. - Implement asynchronous element info retrieval in getElementInfo for improved source mapping. - Enhance error handling in build.js for better build process visibility. - Add debug logging capabilities to assist in source location issues.
…upport Merge branch 'dev-feat-supportReact19' from Feahter/locatorjs fork. Resolve merge conflicts in buildLink.ts and sharedOptionsStore.ts, combining nvim tmuxSession support with Turbopack [project]/ path handling and debugMode option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Translate all Chinese comments and strings to English (14+ files) - Fix unconditional preventDefault in clickListener (two-phase approach) - Remove duplicate ReactDevtoolsHook global declaration - Fix react-devtools-hook build (noEmit: false in tsconfig) - Add tests for sourceMapResolver (VLQ, mappings, fileUrlToPath) - Add tests for buildLink Turbopack [project]/ prefix resolution - Add tests for debug mode toggle and logging - Export internal functions for testability - All 44 tests pass, all builds clean Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| function logStep(step, message) { | ||
| log(`\n[$${step}] ${message}`, "blue"); |
There was a problem hiding this comment.
logStep outputs spurious dollar sign in step label
Low Severity
The logStep function uses `\n[$${step}]` which produces a literal $ before the step number (e.g., [$1] instead of [1]). The extra $ before ${step} is a literal dollar sign in the template string, making step headers display as [$1], [$2], [$3] instead of the intended [1], [2], [3].
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| export function clearComponentSourceCache(): void { | ||
| // WeakMap cannot be cleared, would need to create a new one | ||
| // In practice, WeakMap automatically garbage-collects unreferenced keys | ||
| } |
There was a problem hiding this comment.
Unused exported functions never called anywhere
Low Severity
clearComponentSourceCache is exported but is a no-op (empty body with a comment that WeakMap can't be cleared). clearTurbopackCache is exported but never called anywhere in the codebase. These are dead code that could mislead consumers into thinking cache invalidation works when it doesn't.
Additional Locations (1)
…umbers - Options.tsx: Add .catch() to getElementInfoAsync promise chain - clickSourceResolver.ts: Remove dead clearComponentSourceCache no-op - clickSourceResolver.ts: Add comments explaining 1500/800 search ranges - reactAdapter.ts: Remove redundant resolveSourceFromFiber call in diagnose (findDebugSourceAsync already calls it internally)
1 participant
Summary
Merged and reworked PR #199 from Feahter's fork adding React 19/Next.js 15+/Turbopack source resolution support. Major cleanup: translated all Chinese strings to English, fixed unconditional preventDefault, resolved type conflicts, and added comprehensive test coverage for new resolution strategies.
Changes
noEmit: falseto tsconfigVerification
✅ All 44 tests pass (33 new + 11 existing)
✅ All packages build clean (shared, runtime, react-devtools-hook, extension)
✅ Zero Chinese characters remaining in codebase
Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com
Note
Medium Risk
Touches core element-to-source resolution and click-to-navigate flow (now async with multiple fallbacks), which could affect navigation reliability and performance in dev environments; changes are localized to dev tooling/runtime behavior with added tests and debug instrumentation.
Overview
Improves LocatorJS navigation for React 19 / Next.js (Turbopack) by adding an async fallback path when sync Fiber source metadata is missing, including a new React click resolver that can use DevTools
rendererInterfaces,_debugInfo/_debugStack, source-map reverse lookup, and Turbopack chunkjsxDEVparsing.Adds Debug Mode (UI toggle +
window.__LOCATORJS_DEBUG__) with console tracing/history and awindow.locatorDiagnose()helper; wires debug state through persisted options, and updates the runtime click handler to onlypreventDefaultimmediately when a link is found (or before awaiting async resolution).Also updates link building to resolve Turbopack
[project]/paths, hardens WeakMap ID helpers against non-object keys, adjusts shared React DevTools types for React 19, adds a newapps/next-16-turbopackrepro app, expands tests around source-map parsing/debug/link building, and refreshes extension docs/scripts with a new node-based release packager.Written by Cursor Bugbot for commit 82f29d2. This will update automatically on new commits. Configure here.