Release v1.1.5 and Client proxying fix#295
Merged
Merged
Conversation
Contributor
|
This appears to fix the issue in the US Quality Core test kit. My best guess is that this was a dependency update issue within inferno_core 1.4.0 (perhaps the oj bump?), which this seems to fix? Note that there are a couple of other test kits with the same issue: https://github.com/search?q=org%3Ainferno-framework+%22def+replace_bundle_urls%22&type=code |
karlnaden
marked this pull request as ready for review
July 13, 2026 18:23
ljtucker
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proxying of request to the client suite FHIR endpoints to the reference server was failing in deployed environments due to a combination of json gem inconsistencies and a varied object structure introduced by the url replacement method. Now, that method keeps the FHIR object structure consistent to resolve the issue.
Testing Guidance
Deploy to QA and confirm that running the client vs server suite works correctly.