Skip to content

Center images when the footer is hidden - #229

Merged
infeng merged 1 commit into
masterfrom
codex/fix-no-footer-spacing-130
Aug 21, 2026
Merged

Center images when the footer is hidden#229
infeng merged 1 commit into
masterfrom
codex/fix-no-footer-spacing-130

Conversation

@infeng

@infeng infeng commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • treat the effective footer height as zero when noFooter is enabled
  • keep footerless images centered during initial layout, reset, and resize
  • extend the noFooter test to assert that no vertical space is reserved

Related to #130. The issue is intentionally left open pending maintainer confirmation.

Root cause

The footer DOM was hidden, but layout calculations still subtracted the fixed 84px footer height. This moved the image center 42px above the viewport center.

Validation

  • npm run verify
  • registry scan: only https://registry.npmjs.org/
  • Chromium 149.0.7827.55: before fix center offset -42px; after fix 0px
  • Chromium resize check: center offset remains 0px; no page errors

@infeng
infeng marked this pull request as ready for review August 21, 2026 03:01
@infeng
infeng merged commit 6c741af into master Aug 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant