Skip to content

🪛fix: use client-side routing for About Us link (#74)#89

Open
nitishchaubeyy wants to merge 1 commit into
indresh404:mainfrom
nitishchaubeyy:fix/about-client-routing
Open

🪛fix: use client-side routing for About Us link (#74)#89
nitishchaubeyy wants to merge 1 commit into
indresh404:mainfrom
nitishchaubeyy:fix/about-client-routing

Conversation

@nitishchaubeyy
Copy link
Copy Markdown
Contributor

Description

Resolves #74

This PR updates the "About Us" navigation links across the application to utilize standard client-side routing, preventing the disruption of the SPA user flow caused by opening internal links in a new browser tab.

🚀 Changes Made:

  • Removed target="_blank" and rel="noopener noreferrer" attributes from the <Link> components pointing to /about in the following files:
    • src/components/layout/PublicNavbar.jsx
    • src/components/layout/Sidebar.jsx
    • src/components/layout/MobileSidebar.jsx
    • src/components/layout/PublicFooter.jsx

🧪 Testing Done:

  • Verified clicking "About Us" in the public navbar smoothly routes within the same tab.
  • Verified clicking "About Us" in the authenticated desktop sidebar routes internally.
  • Verified clicking "About Us" in the mobile drawer routes internally and closes the drawer.
  • Verified clicking "About Us" in the footer correctly handles the internal routing.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ranker-hub Ready Ready Preview, Comment May 30, 2026 9:22pm

@github-actions github-actions Bot added backend Backend/Firebase related changes bug Something isn't working enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend/Firebase related changes bug Something isn't working enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Use client-side routing for "About Us" link instead of opening a new tab

1 participant