[ng-components] base list add debounce and minimum character search#91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debounce and minimum character search functionality to the ng-components base list component. The changes introduce a search subject-based pipeline with debouncing, filtering for minimum character requirements, and deduplication logic. The feature is also integrated into the controls sample list component to demonstrate the functionality.
Changes:
- Added debounce time (1000ms) and minimum search characters (3) configuration to BaseListComponent
- Implemented a Subject-based reactive pipeline with filter, debounce, and distinctUntilChanged operators for search queries
- Integrated the new search functionality into the controls sample list component with filtering logic
- Added HTML template binding for the search input event
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/ng-components/src/lib/helpers/base-list.component.ts | Added search debounce mechanism with minimum character requirement and proper subscription cleanup |
| projects/app/src/app/features/controls/controls-samples-list/controls-samples-list.component.ts | Integrated search functionality with client-side filtering of samples by title and description |
| projects/app/src/app/features/controls/controls-samples-list/controls-samples-list.component.html | Added search event binding to the view layout component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update npm-publish.yml to add a check that skips publishing if the current package version is already available on the npm registry. Introduce a publish_if_new function to handle this logic for @indice/ng-auth, @indice/ng-components, and @indice/ng-config.
… in beta publish script
…ion checking in main publish workflow and add beta publish script for ng-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.