Skip to content

cli: correct fs help and learn.md - #30

Closed
mgasner wants to merge 1 commit into
fix/fs-grepfrom
fix/fs-help
Closed

mgasner wants to merge 1 commit into
fix/fs-grepfrom
fix/fs-help

Conversation

@mgasner

@mgasner mgasner commented Sep 28, 2026

Copy link
Copy Markdown

Stacked on #29; the diff shows only this change.

This corrects the fs help text that disagreed with the code and the design:

  • --no-ignore: results stay in path order, and ignored files are marked. The help used to say they "rank after tracked ones".
  • fs sync PATH: relative to the client's cwd, not the server's.
  • learn.md:
    • Uses yas fs mkdir --parents and yas fs rm. The -p and -r flags it showed don't exist.
    • Adds an fs grep -m 3 example.
    • Describes the .git, dotfile, and --no-ignore behavior.

View in Indent
Tag @indent to continue the conversation here.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Coverage

Crate Lines Functions Regions
alacritty-driver 85.6% (1081/1263) 89.4% (84/94) 89.3% (1746/1955)
browser 25.5% (309/1212) 30.4% (34/112) 27.7% (605/2183)
cli 34.2% (6797/19893) 36.3% (644/1776) 35.3% (10106/28641)
client 68.3% (5800/8497) 68.5% (708/1033) 66.4% (7525/11331)
composite-transport 96.3% (526/546) 98.4% (60/61) 96.2% (884/919)
compositor 55.0% (11458/20820) 66.2% (838/1265) 54.9% (15871/28909)
desktop 78.4% (4460/5691) 71.6% (393/549) 75.1% (6211/8267)
edge 62.9% (798/1268) 50.9% (82/161) 57.7% (1038/1799)
fonts 77.3% (1257/1626) 82.7% (129/156) 78.9% (2424/3071)
fssync 85.7% (1605/1872) 85.8% (182/212) 86.9% (2827/3255)
git 72.9% (4622/6344) 70.5% (347/492) 70.1% (6590/9407)
guest 67.3% (6829/10148) 67.0% (488/728) 66.6% (8935/13416)
lsp 79.9% (3641/4558) 81.3% (340/418) 77.7% (5489/7068)
proxy 63.1% (1902/3012) 56.3% (184/327) 63.4% (2931/4626)
runtime-dir 93.6% (117/125) 100.0% (14/14) 94.8% (218/230)
sd-notify 73.9% (68/92) 100.0% (6/6) 83.2% (109/131)
server 71.5% (86299/120750) 74.1% (6265/8455) 69.4% (115616/166506)
ssh 67.2% (708/1054) 75.9% (85/112) 67.2% (1105/1645)
terminal-model 49.9% (314/629) 62.3% (38/61) 50.3% (505/1004)
uplink 94.2% (582/618) 92.6% (50/54) 93.1% (1062/1141)
webrtc-forwarder 33.6% (1321/3932) 44.9% (146/325) 36.0% (2279/6336)
webserver 80.7% (1490/1846) 81.1% (193/238) 83.2% (2551/3067)
website 35.1% (355/1012) 34.4% (53/154) 35.8% (607/1694)
xtask 0.0% (0/5149) 0.0% (0/131) 0.0% (0/9157)
yas 89.0% (28040/31522) 94.1% (2152/2286) 84.1% (44040/52388)
Total 67.2% (170379/253479) 70.3% (13515/19220) 65.5% (241274/368146)

@indent
indent Bot force-pushed the fix/fs-help branch 2 times, most recently from 750e6d5 to 8581425 Compare October 14, 2026 19:54
--no-ignore results are in path order, not ranked after tracked files;
fs sync PATH resolves against the client's cwd; -m 0 means no limit.
learn.md used `fs mkdir -p` and `fs rm -r`, which do not exist; they are
`--parents` and plain `rm`.
@indent
indent Bot deleted the branch fix/fs-grep October 15, 2026 13:07
@indent indent Bot closed this Oct 15, 2026
@indent
indent Bot deleted the fix/fs-help branch October 15, 2026 13:07
pcarrier pushed a commit to yas-run/yas that referenced this pull request Oct 15, 2026
Stacked on #47. Review only the top commit, "cli: correct fs help and learn.md".

This fixes help text and `learn.md`:

- The `--no-ignore` help now says results stay in path order.
- The `fs sync PATH` help now says the path is relative to the client's cwd.
- `learn.md` used flags that don't exist: `fs mkdir -p` is now `fs mkdir --parents`, and `fs rm -r` is now `fs rm`.

Fork PR with the isolated diff: indent-com#30.

[![View in Indent](https://assets.indent.com/view-in-indent.svg)](https://app.indent.com/c/01a0db15-330c-717e-9ec3-032c80770b1c)
Tag `@indent` to continue the conversation here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant