all: remove go-colorable from log15 modules#182
Merged
Conversation
Write terminal output directly when stdout or stderr is a terminal and use x/term for terminal detection. This removes the go-colorable and go-isatty module edges from the root and v3 modules. Keep the deprecated root term package API available: IsTty now delegates to x/term.IsTerminal, and the exported Termios types remain for source compatibility but are marked deprecated. go-colorable was a pass-through to os.Stdout and os.Stderr on non-Windows platforms. On Windows this drops go-colorable's fallback ANSI escape translation for older consoles; modern Windows terminals can handle ANSI output directly. Update compat to the latest currently reachable legacy log15 pseudo-version and the v3.1.0 tag, without adding a local parent-module replace. A follow-up change can move compat to this commit's pseudo-version after it is reachable remotely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write terminal output directly when stdout or stderr is a terminal and use x/term for terminal detection. This removes the go-colorable and go-isatty module edges from the root and v3 modules.
Keep the deprecated root term package API available: IsTty now delegates to x/term.IsTerminal, and the exported Termios types remain for source compatibility but are marked deprecated.
go-colorable was a pass-through to os.Stdout and os.Stderr on non-Windows platforms. On Windows this drops go-colorable's fallback ANSI escape translation for older consoles; modern Windows terminals can handle ANSI output directly.
Update compat to the latest currently reachable legacy log15 pseudo-version and the v3.1.0 tag, without adding a local parent-module replace. A follow-up change can move compat to this commit's pseudo-version after it is reachable remotely.