Repository navigation
Conversation
linson007
marked this pull request as ready for review
October 22, 2026 17:09
This was referenced Oct 22, 2026
Contributor
Author
|
Additional current-head native capture/replay qualification The actual native binary used the current PR head
This additional matrix used ordinary contexts ( Full report and reproduction · native/results.json · native/comparison.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native fresh-versus-restored-prefix probe and a matched-context comparator for #548. The probe explicitly materializes a page-aligned prefix, snapshots the real composite state, moves the request to another state lane, restores it, rebuilds draft rings and resumes the same prompt. Fresh controls use identical materialization and prefill chunk boundaries.
Captured context hashes include the pending anchor. The comparator rejects mismatched model/prompt/precision/policy/budget settings, pairs only identical contexts and reports censored acceptance, proposal changes, verify-row choices, selector-confidence changes and optional BF16 final-hidden drift. Adaptive capture can freeze the prior/cost seed, avoiding online timing-learning confounds. Native scratch matches beyond retained/verified rows are censored.
Native evidence
The checked-in, hash-verified archive contains 12 captures / 48 cycles / 24 matched-context pairs on Apple M5 Pro (48 GiB, macOS 26.6): released dense and MoE DFlash2 drafts with their MLX 4-bit targets, 2112/8256-token source-review prompts, INT8/BF16 KV, and full/frozen-adaptive verify budgets.
Validation
MTL_SHADER_VALIDATION=1, including hidden-row readback.Runtime.cpppreprocesses byte-identically to upstream main (SHA25611c4aac9285dae98a7f4db0f053072bfe83ac57beb99d77b3ed31c1130a77f38); extra accessors/reset hooks exist only in instrumented builds.Additional test limitation: combined
MTL_DEBUG_LAYER=1 MTL_SHADER_VALIDATION=1hit aprefill_gdn_scan_vh32threadgroup-memory assertion (35072 > 32768) on this host. That extra check did not pass; it occurs in the unchanged target kernel, and the same assertion reproduced on the unchanged #550 baseline binary. Shader-validation-only capture passed. The failure is recorded in the validation artifact.Dependencies and remaining gates
Ready-for-review follow-up to #550; merge #550 first. Based on
ef0e95d4fa09f265f1cb071d43591ff32367b372; upstreammainremains the base, so #550's parent capture changes are visible until it merges. Review only this follow-up here: experiment diff.The research issue stays open. These are short source-review mechanics probes, not a broad long-context retrieval or task-quality benchmark. SSD/suspend restoration, larger contexts, direct ring reconstruction references, paired serving timings and any trained global-memory/window experiment remain unqualified. Capture I/O is unsuitable for throughput claims. No production architecture or checkpoint default is changed.
Trained-export native replay
Published CUDA/native evidence adds native loading and capture/replay of the released Qwen3.8-27B draft and four actual CUDA-trained BF16 exports: 540 lane-cycles on the same 4-bit target, INT8 KV, FP32 state, greedy decoding, all verification rows and frozen budget learning. All twenty sanitized published captures replay exactly. Non-draft input digests match across all five assemblies, and target output common prefixes agree in every comparison. No consistent acceptance improvement or throughput claim is supported by these four short prompts. This adds use of the existing diagnostics at
b4006b12cdd7, without modifying its implementation.The pinned teacher template defaults to thinking enabled with
xhighreasoning effort; native probes explicitly disabled thinking. This mode mismatch, together with the BF16/low-bit target difference and short captures, prevents a matched-distribution effectiveness conclusion. Future capture controls should make thinking mode explicit and include it in cache/run provenance.