Repository navigation
Conversation
linson007
force-pushed
the
feat/dflash2-mps-training
branch
from
October 21, 2026 18:13
4c11f7b to
2fe5fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple Silicon users can select
--device mpsfor optional DFlash2 capture, preflight, training, resume, and final evaluation.Depends on #499. Please merge the parent first. This upstream PR targets
main, so it currently includes the parent training changes. The Mac-only follow-up is commit 2fe5fe39. After #499 merges, rebase that follow-up onto current main to isolate the final diff. This remains draft pending real-checkpoint qualification.The Mac follow-up adds:
Validation on an Apple M5 Pro with 48 GB unified memory, macOS 26.6, Python 3.12.14, PyTorch 2.13.0, and Transformers 5.15.1:
The full ordinary/native suite was not rerun for the Mac follow-up. No real Qwen3.8-27B MPS training, production CUDA run, or trained-checkpoint native qualification is claimed.
Testing help wanted: contributors with sufficient unified memory for the full BF16 teacher can help measure real-checkpoint preflight, training memory/step time, resume, export, and native acceptance/throughput. Teacher weights alone are approximately 54 GB before working memory. The current command runs capture and training on the selected backend and does not provide cross-device cached-feature training.
The smoke test needs no model downloads after installing
training/requirements.txtin a separate environment:Please follow the guide's reporting checklist for hardware, versions, input revisions, recipe/split fingerprints, memory, timings, and errors.
Need help on this PR? Tag
@codesmith-botwith what you need.