bidsmri2nidm: capture BIDS field maps with a FieldMap image-usage type - #452
Merged
Conversation
… index in anat branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures BIDS field-map acquisitions that were previously dropped or mislabeled, validated to produce graphs isomorphic to the LinkML refactor via typed-shape A/B on real ABIDE data.
Build the pybids layout with validate=False so real-world non-conformant files (e.g. ABIDE II field maps placed under dwi/) are captured rather than silently dropped by BIDS validation.
New nidm:FieldMap image-usage type (Constants.NIDM_MRI_FIELDMAP) plus BIDS_Constants entries for the fmap datatype and field-map suffixes (fieldmap, magnitude, magnitude1/2, phasediff, phase1/2, epi). Field-map scans are now labeled FieldMap instead of mislabeled DiffusionWeighted. (Vocabulary term proposed to nidm-experiment separately.)
Emit the BIDS run index in the anat branch (it was only emitted for func/dwi).
Validation: typed-shape parity (scripts/parity_compare.py) legacy vs LinkML — ABIDE Caltech PARITY OK (6,635 instances) and ABIDE II NYU_1 PARITY OK (42,211 instances; exercises DWI, field maps, multi-run, multi-session).