Skip to content

Deps (Web): Upgrade Vite to version 8#54

Draft
losolio wants to merge 1 commit into
mainfrom
chore/web-vite-8
Draft

Deps (Web): Upgrade Vite to version 8#54
losolio wants to merge 1 commit into
mainfrom
chore/web-vite-8

Conversation

@losolio
Copy link
Copy Markdown
Contributor

@losolio losolio commented May 3, 2026

Bump Vite to version 8.

Copilot AI review requested due to automatic review settings May 3, 2026 21:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the Ignis.Web build/test toolchain to Vite 8 and removes vite-tsconfig-paths, updating Vite/Vitest configuration to rely on Vite’s native tsconfig path handling.

Changes:

  • Bump vite from ^7.3.2 to ^8.0.10 and remove vite-tsconfig-paths from devDependencies.
  • Update vite.config.ts and vitest.config.ts to replace the plugin with resolve.tsconfigPaths: true.
  • Refresh package-lock.json for the new dependency graph (notably introducing rolldown via Vite 8).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/Ignis.Web/vitest.config.ts Removes vite-tsconfig-paths usage and switches to resolve.tsconfigPaths.
src/Ignis.Web/vite.config.ts Removes vite-tsconfig-paths plugin and switches to resolve.tsconfigPaths.
src/Ignis.Web/package.json Upgrades Vite to v8 and removes vite-tsconfig-paths dependency.
src/Ignis.Web/package-lock.json Updates lockfile for Vite 8 and removes vite-tsconfig-paths transitive deps.
Files not reviewed (1)
  • src/Ignis.Web/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"typescript-eslint": "^8.59.1",
"vite": "^7.3.2",
"vite-tsconfig-paths": "^5.1.4",
"vite": "^8.0.10",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, will await an update of @react-router/dev before merging

Comment on lines +6532 to 6536
"node_modules/vite-node/node_modules/vite": {
"version": "7.3.2",
"resolved": "https://registry.npmjs.org/vite/-/vite-7.3.2.tgz",
"integrity": "sha512-Bby3NOsna2jsjfLVOHKes8sGwgl4TT0E6vvpYgnAYDIF/tie7MRaFthmKuHx1NSXjiTueXH3do80FMQgvEktRg==",
"dev": true,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will await upgrade to avoid this conflict

@losolio losolio marked this pull request as draft May 3, 2026 22:45
@losolio
Copy link
Copy Markdown
Contributor Author

losolio commented May 5, 2026

As @react-router/dev is pulling in vite-node@3.2.4, with vite dependency ^5 || ^6 || ^7 we are getting both vite v7 and v8. As we have no needs for vite v8, we will just put this on hold until all dependencies are supporting vite 8

@losolio losolio force-pushed the chore/web-vite-8 branch from 922be5b to aa220bf Compare May 18, 2026 18:46
@losolio losolio changed the title Upgrade Vite to version 8 and remove vite-tsconfig-paths Deps (Web): Upgrade Vite to version 8 May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants