DON'T MERGE!! Label nodes for oculus-touch-v3 - #281
Open
AdaRoseCannon wants to merge 1 commit into
Open
Conversation
Adds per-component `<rootNodeName>_label` nodes to left/right GLBs at positions chosen to face outward from the controller surface, so experiences can anchor tooltips/text to each button, trigger, squeeze, thumbstick, and thumbrest. - GLBs: embed `_label` empty nodes (local +Y outward) under each component's root subtree. - profile.json: declare matching `labelTransform` overrides (position + quaternion in gltf.scene-local / grip space) so consumers who can't parse the GLB still get the placement. - layout.schema.json: allow `labelTransform` on a component.
Member
Author
|
A visual: |
Member
Author
|
@toji I've made a little tool so I can easily annotate every model and JSON, can you review this to make sure it is what you had in mind and if it is then I will do every single one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to immersive-web/webxr#1428
I took a stab at seeing what it would look like for a single controller.
This is just a POC to see if this is the kind of thing that we had in mind.
Adds
<rootNodeName>_labelnodes to left/right GLBs at positions chosen to face outward from the controller surface, so experiences can anchor tooltips/text to each button, trigger, squeeze, thumbstick, and thumbrest._labelempty nodes (local +Y outward) under each component's root subtree.labelTransformoverrides (positionlabelTransformon a component./facetoface