docs: count the empty-queue reasons correctly, and say what CI actually enforces - #21
Merged
Merged
Conversation
…ly enforces Four corrections, no behaviour. Two comments still describe four empty-queue reasons. There have been six since stage 4 landed and added `unverified`: the CI packaging step's note and the terminal path's explanation of why one shared line will not do. Both are the same drift `install.py` already documents as the reason `doctor` checks a skill for staleness — "a skill that lists five reason codes is a skill inviting the model to flatten the sixth into one it recognises." That sentence stays as written; it is history, and it was right. The one that costs someone time: CI now runs pytest under coverage against an 84% floor, and CONTRIBUTING said "the three checks" and listed pytest, ruff, mypy. A contributor whose change drops the number fails on a rule documented nowhere they would look. It is written down now, with the command to see it locally and the note that nothing is excluded from the measurement. And `reprobe` is in the corpus tools list, where it has been missing since it shipped. It was findable only in design.md, which is not where anyone goes for a command to run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four corrections found while checking whether rc7 left the README stale. It did not —
grask statswent in with the release and nothing else in rc7 is user-visible — but these turned up next to it. No behaviour changes, and nothing here ships in the wheel, so this does not need a release..github/workflows/ci.ymlsrc/grask/cli.pyCONTRIBUTING.mdCONTRIBUTING.mdsurvey,triage_run,capture_runreprobewas missingThe two counts drifted at rc6, when stage 4 added
unverifiedas a sixthempty_reason.install.pyalready documents exactly this failure mode as the reasondoctorchecks an installed skill for staleness — "a skill that lists five reason codes is a skill inviting the model to flatten the sixth into one it recognises." That sentence is left alone: it is a historical account and it was correct.The coverage floor is the one worth having. It went into CI last release and was documented nowhere a contributor reads, so a PR that drops the number would fail on an invisible rule. CONTRIBUTING now states the floor, says it ratchets, notes that nothing is excluded from the measurement to flatter it, and gives the local command.
🤖 Generated with Claude Code