Separate single-bucket entity from accounts and unify add flow#1
Closed
Separate single-bucket entity from accounts and unify add flow#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Accountor aSingle Bucketbefore entering credentials.Description
SingleBucketConfigandSingleBucketDao, and added a Flyway migrationV2__add_single_bucket_support.sqlto create thesingle_bucketstable.AccountConfig/AccountDaoto be account-only and removed the previoussingleBucketNamefield from the account persistence model.AccountDialogthat has anEntryTypeselector (ACCOUNT/SINGLE_BUCKET) and returns aConnectionInput; deleted the oldSingleBucketDialog.MainWindowto handle two distinct flows (persist/load/connect/delete) forAccountConfigvsSingleBucketConfig, to create sessions for single-bucket entries, and to normalize/validate inputs with new helpers (normalizeSingleBucket,toSessionAccountConfig,validateConnectionInput).addSingleBucket/updateSingleBucketmethods and anAccountNodevariant that carries asingleBucketflag andbucketName.Add Connectionand to disable theCreate bucketaction for single-bucket entries viaAccountContextMenu.Testing
./gradlew testwhich failed in this environment becausepublishing.gradleexpects thegiteaTokenproperty and the build evaluation aborts../gradlew test -PgiteaToken=dummywhich failed during dependency resolution due to HTTP 403 from Maven Central in this environment so compilation/tests could not complete../gradlew compileJava -PgiteaToken=dummy --offlinewhich failed because no dependency cache is available offline, so compilation could not be validated locally.Codex Task