Skip to content

Add message for commit retries on failure #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoIMC merged 1 commit into from
Aug 28, 2025
Merged

Add message for commit retries on failure #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,13 +811,24 @@ def _before_attempt(state: RetryCallState):
self._apply(*op._commit())
logger.debug(f"Committing transaction...")

def _error_callback(state: RetryCallState):
msg = (
f"Failed to commit transaction after {state.attempt_number:,} attempts."
f" Try increasing the value of the `{COMMIT_NUM_RETRIES}` property on your table."
)
if state.outcome and (excp := state.outcome.exception()):
excp.args = (msg + "\n\n" + excp.args[0],)
raise excp

raise CommitFailedException(msg)

@wraps(self.commit_transaction)
@retry(
wait=wait_random_exponential(min=min_wait_ms / 1000, max=max_wait_ms / 1000),
stop=stop_after_attempt(num_retries),
retry=retry_if_exception_type(CommitFailedException),
before=_before_attempt,
reraise=True,
retry_error_callback=_error_callback,
)
def _commit_transaction():
if len(self._updates) > 0:
Expand Down
Loading