fix(security): restrict credentialed CORS to trusted frontend origins#736
Open
RachanaB5 wants to merge 1 commit into
Open
fix(security): restrict credentialed CORS to trusted frontend origins#736RachanaB5 wants to merge 1 commit into
RachanaB5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733
Summary
This PR hardens backend CORS configuration by replacing wildcard credentialed CORS with an explicit, environment-driven origin allowlist.
Changes
CORS_ALLOW_ORIGINSparsing to backend settings..env.example, and Render config.Why This Matters
The API exposes authenticated endpoints such as
/auth/meand/user/*. Allowing*origins with credentials creates an overly broad browser trust boundary and makes production deployments harder to secure.This change keeps local development working while making production CORS explicit.
Testing
python3 -m compileall backend/app/config.py backend/app/main.py backend/tests/test_endpoints.pylibmagicon this machine:ImportError: failed to find libmagicThe new tests should run in CI or any environment with the backend native dependencies installed.