fix: replace deprecated classmethod model_validator with instance method in ShareCreateRequest#722
Open
Xenon010101 wants to merge 2 commits into
Open
Conversation
…hod in ShareCreateRequest Pydantic V2.12+ deprecates using @model_validator(mode='after') on @classmethods. Changed ShareCreateRequest.validate_fields to an instance method and added non-empty validation for code and result fields. Fixes deprecation warning: PydanticDeprecatedSince212: Using @model_validator with mode='after' on a classmethod is deprecated. Closes imDarshanGK#719
Renamed the storage key used for persisting theme preference to match the application prefix, preventing key collision with other scripts. Closes imDarshanGK#717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pydantic V2.12+ deprecates using @model_validator(mode='after')\ on @classmethods. This PR converts the validator to a proper instance method and adds non-empty validation for \code\ and
esult\ fields.
Changes
Testing
Closes #719