Skip to content

[refactor] update Pydantic mode='after' validator to instance method to fix deprecation warning #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Siddhazntx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[refactor] update Pydantic mode='after' validator to instance method to fix deprecation warning #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions backend/app/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,10 @@ def parse_result_json(cls, values: dict[str, Any]) -> dict[str, Any]:
return values

@model_validator(mode="after")
@classmethod
def ensure_result_present(cls, model: "ShareCreateRequest") -> "ShareCreateRequest":
if model.result is None:
def ensure_result_present(self) -> "ShareCreateRequest":
if self.result is None:
raise ValueError("result or result_json is required")
return model
return self


class ShareRecord(BaseModel):
Expand Down