Skip to content

Java 17 modernization, fixed the polymorph sometimes not working, tons of refactoring for the fabric version ONLY#333

Open
ImEden6 wants to merge 4 commits into
illusivesoulworks:1.20.xfrom
ImEden6:main
Open

Java 17 modernization, fixed the polymorph sometimes not working, tons of refactoring for the fabric version ONLY#333
ImEden6 wants to merge 4 commits into
illusivesoulworks:1.20.xfrom
ImEden6:main

Conversation

@ImEden6

@ImEden6 ImEden6 commented Jul 9, 2026

Copy link
Copy Markdown

Java Modernization and some Warning Cleanups

Pattern Matching instanceof: Refactored redundant castings after instanceof checks across these classes:

  • SmithingRecipeWrapper.java
  • PolymorphCommonMod.java
  • PolymorphClient.java
  • MixinRecipeManager.java
  • CPacketPlayerRecipeSelection.java
  • QuickBenchModule.java
  • PlayerRecipeData.java

Mixin Suppressions Documented: Added comments explaining the runtime context of @SuppressWarnings("unused") in Mixins to document ECJ info messages safely.

Stack Component Delegation Refactoring & NBT Serialization Fix

Used Composition over Inheritance

  • Refactored AbstractStackRecipeDataComponent to hold a private StackRecipeData delegate, removing 200 lines of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant