Implement SafeComponentHandle and earlier managed cleanup - #552
Merged
Merged
Conversation
.NET libraries test results518 tests 518 ✅ 16s ⏱️ Results for commit c28d16d. ♻️ This comment has been updated with latest results. |
ikkentim
commented
May 12, 2026
| } | ||
| } | ||
|
|
||
| void SampSharpComponent::provideConfiguration(ILogger& logger, IEarlyConfig& config, const bool defaults) |
Owner
Author
There was a problem hiding this comment.
Undo (most) formatting changes in all cpp/hpp files
Closed
ikkentim
added a commit
that referenced
this pull request
May 14, 2026
* origin/main: Disable IDE0290 configuration and revert public primary constructors (#560) Clean up legacy editorconfig Sonar overrides and eliminate TODO markers in `src/legacy` (#562) Add implicit usings to SampSharp.Sdk (#558) Add `dotnet new` template package for open.mp ECS gamemodes (#556) Add clang-format configuration and apply to sampsharp-component C++ source files (#554) Implement SafeComponentHandle and earlier managed cleanup (#552)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onFree(IComponent)can be forwarded to the managed code, where pointers to the component may be unsetcomponent.freeinstead ofextension.freeExtension. OurEcsHostextension was attached toICore, which gets freed whenICoregets freed