Migrate pure-C# solutions to slnx and remove legacy vcxproj files - #461
Merged
Conversation
Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/c52a8c19-8e99-4d86-be74-5e837ddc3a5c Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate pure-C# solutions to slnx and clean up
Migrate pure-C# solutions to slnx and remove legacy vcxproj files
Apr 30, 2026
ikkentim
requested changes
Apr 30, 2026
ikkentim
left a comment
ikkentim
left a comment
Owner
There was a problem hiding this comment.
Rename the legacy solution SampSharp.Legacy
Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/d24e3568-200f-4535-91d2-7ef037ae3f95 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>
Contributor
Author
Done in 406ce3a. Renamed |
ikkentim
requested changes
Apr 30, 2026
ikkentim
left a comment
ikkentim
left a comment
Owner
There was a problem hiding this comment.
On master branch, Directory.Packages.props were added in root and src/legacy. Add them as items to their respective slnx files
Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/6ee3cfae-6c08-48e2-9de4-3256dd4c824a Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>
Contributor
Author
Done in 48e1fb7. Added |
ikkentim
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates both pure-C# solution files to the newer XML-based
.slnxformat and removes the legacy MSVC project files that are now superseded by CMake.Solution migration
SampSharp.sln→SampSharp.slnxandsrc/legacy/SampSharp.sln→src/legacy/SampSharp.Legacy.slnxviadotnet sln migrateMixed Platforms,Win32) from the legacy slnx.DotSettingsfiles to match new solution filenamesDirectory.Packages.propsas a solution item in bothSampSharp.slnxandSampSharp.Legacy.slnxDeleted files
src/legacy/SampSharp.Plugin.sln— redundant, CMake is the build system nowsrc/legacy/SampSharp/SampSharp.vcxproj+.vcxproj.filters— same reasonBuild/CI updates
build.cmd/build.sh: alldotnet build/pack SampSharp.slncalls updated toSampSharp.slnx/SampSharp.Legacy.slnx.github/workflows/dotnet-component.yml: path filter updated fromSampSharp.sln→SampSharp.slnx