Skip to content

Restore parameterless Player constructor for testability #594

Description

@DevD4v3

Previous versions exposed a protected parameterless constructor:

protected Player()
{
}

This allowed creating lightweight test doubles by deriving from Player and overriding virtual members such as Name, Team, Health, etc.

The current constructor requires IOmpEntityProvider and IPlayer instances:

protected Player(IOmpEntityProvider entityProvider, IPlayer player)

which makes it difficult to create fake Player implementations for unit tests without depending on runtime infrastructure.

Would it be possible to restore the parameterless constructor for testing scenarios?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions