Repository navigation
refactor(cli): split the build pipeline into named phases - #26
Merged
Merged
Conversation
RunBuild is now a short orchestrator over three nested phases: ParseCommandLine, ExecuteBuild, and RenderAndReport. The phases share the existing locals, so no option or build-state record is threaded, and the single outer try/finally remains the only owner of the option objects. No behavior changes; the CLI suite covers help, exit codes, incremental parity, coverage policy, and source links. Verified: make test (CLI and functional suites) and byte-identical checked-in example output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final Stage D slice:
RunBuildinsrc/cli/PasWeave.CLI.pasis split into named phases. The procedure body drops from ~470 lines to a ~47-line orchestrator:ParseCommandLine--helpExecuteBuildRenderAndReportThe phases are nested procedures that share the existing locals, so no option or build-state record is threaded and the single outer
try/finallyremains the only owner of the option objects.One behavior-preserving detail:
--helpinsidepasweave buildnow sets a handled flag instead of callingExit(0)from a nested procedure (nested procedures cannot return a value).Verification
make testpasses (CLI suite covers help, usage errors, exit codes, incremental parity, corruption recovery, coverage policy, and source links).This completes the Stage D decomposition program.