Skip to content

fail CI on secret-handling mistakes the linters miss#236

Merged
iicky merged 2 commits into
mainfrom
test/secret-invariant-lints
Jun 18, 2026
Merged

fail CI on secret-handling mistakes the linters miss#236
iicky merged 2 commits into
mainfrom
test/secret-invariant-lints

Conversation

@iicky

@iicky iicky commented Jun 18, 2026

Copy link
Copy Markdown
Owner
  • fail CI when library code reads MURK_KEY outside the env module, writes a secret to stdout, or ships a dbg!
  • add tests/invariants.rs scanning src for these rules, and deny clippy's dbg_macro in Cargo.toml
  • route murk init key discovery through env::key_from_env_only so the key env vars are read in one auditable place

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.52%. Comparing base (b395422) to head (82cdc76).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/env.rs 86.66% 0 Missing and 2 partials ⚠️
src/init.rs 0.00% 0 Missing and 1 partial ⚠️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iicky iicky merged commit fbe9bc9 into main Jun 18, 2026
30 checks passed
@iicky iicky deleted the test/secret-invariant-lints branch June 18, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant