Cloud Run成果物へソースコミットを記録 - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Cloud Runデプロイ時に
VERIFICATION_SOURCE_COMMITへデプロイ対象の完全なGit SHAを設定します。理由
成果物マニフェストは計算に使用したソースコミットを記録しますが、Cloud Runワークフローでは当該環境変数が未設定でした。コンテナにはGit管理情報を含めないため、未修正のままでは
source_commitがunknownになります。影響
計算ロジックや画面表示には影響しません。Cloud Runで生成する成果物の追跡情報だけを正確にします。
確認
github.shaをCloud Run環境変数へ設定