Repository navigation
dash, scrape: tests that do not depend on scheduling - #5
Merged
Merged
Conversation
TestServe took the first event of the stream as the data, but a stream opened before the first scrape finishes starts with an empty frame (seen on the macOS runner). It now reads frames until the metrics arrive, and its first scrape is made slow on purpose to keep that path tested. TestUserAgent waits for the handler call instead of the Close grace, and TestHandlerHung checks the busy error rather than a 10ms bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01US3HyDZUDYV2efX1EkkXgd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4:
TestServefailed on the macOS runner (run).TestServetook the first event of the stream as the data, but a stream opened before the first scrape finishes starts with an empty frame ("scrapes":0), which is intended. It now reads frames until the metrics arrive (5s deadline), and its first scrape is made slow on purpose — that reproduced the CI failure locally and keeps the path tested.TestUserAgentwaits for the handler call instead of relying on the 100ms Close grace.TestHandlerHungchecks the "busy" error instead of a 10ms time bound.Tests only.
make testandgolangci-lintpass;dash,internal/scrape,internal/webpass 30 runs with-raceatGOMAXPROCS=1.🤖 Generated with Claude Code
https://claude.ai/code/session_01US3HyDZUDYV2efX1EkkXgd