Build unsigned desktop release artifacts - #47
Merged
Conversation
- Disable code-signing and notarization in release builds - Keep tag validation and artifact uploads intact
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Architecture diagram
sequenceDiagram
participant GHA as GitHub Actions
participant ES as Electron Builder
participant Sign as macOS Notarization Service
participant CS as Windows Code Signing
participant Artifact as Build Artifact
Note over GHA,Artifact: Desktop Release Build Flow
GHA->>GHA: Checkout repo & install deps
GHA->>GHA: Validate release tag matches app version
GHA->>ES: pnpm --filter @showtime/desktop release:build
alt Windows build
ES->>ES: Build Windows installer (NSIS/portable)
Note over ES,CS: CSC_IDENTITY_AUTO_DISCOVERY=false disables Windows signing
ES-->>GHA: unsigned .exe/nupkg
else macOS build
ES->>ES: Build macOS app (dmg/zip)
Note over ES,Sign: notarize: false in electron-builder config
ES-->>GHA: unsigned .app bundle
else Linux build
ES->>ES: Build Linux AppImage/deb
ES-->>GHA: unsigned AppImage
end
GHA->>Artifact: Upload unsigned artifact (upload-artifact@v4)
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing