Skip to content

Build unsigned desktop release artifacts - #47

Merged
johannesschiessl merged 1 commit into
mainfrom
t3code/remove-singing-app-procedure
Aug 5, 2026
Merged

Build unsigned desktop release artifacts#47
johannesschiessl merged 1 commit into
mainfrom
t3code/remove-singing-app-procedure

Conversation

@johannesschiessl

Copy link
Copy Markdown
Member

Summary

  • Disable code-signing and notarization requirements in the desktop release workflow.
  • Build and upload unsigned Windows, macOS, and Linux release artifacts.
  • Retain release tag validation against the desktop app version.

Testing

  • Not run (CI workflow and Electron Builder configuration changes only).

- Disable code-signing and notarization in release builds
- Keep tag validation and artifact uploads intact

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Architecture diagram
sequenceDiagram
    participant GHA as GitHub Actions
    participant ES as Electron Builder
    participant Sign as macOS Notarization Service
    participant CS as Windows Code Signing
    participant Artifact as Build Artifact

    Note over GHA,Artifact: Desktop Release Build Flow

    GHA->>GHA: Checkout repo & install deps
    GHA->>GHA: Validate release tag matches app version
    GHA->>ES: pnpm --filter @showtime/desktop release:build

    alt Windows build
        ES->>ES: Build Windows installer (NSIS/portable)
        Note over ES,CS: CSC_IDENTITY_AUTO_DISCOVERY=false disables Windows signing
        ES-->>GHA: unsigned .exe/nupkg
    else macOS build
        ES->>ES: Build macOS app (dmg/zip)
        Note over ES,Sign: notarize: false in electron-builder config
        ES-->>GHA: unsigned .app bundle
    else Linux build
        ES->>ES: Build Linux AppImage/deb
        ES-->>GHA: unsigned AppImage
    end

    GHA->>Artifact: Upload unsigned artifact (upload-artifact@v4)
Loading

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/release.yml
@johannesschiessl
johannesschiessl merged commit 4cc5079 into main Aug 5, 2026
2 checks passed
@johannesschiessl
johannesschiessl deleted the t3code/remove-singing-app-procedure branch August 5, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant