Fix startup loading background - #46
Merged
Merged
Conversation
- Match the pre-render and desktop window backgrounds to the dark theme - Use shared background and foreground theme tokens in the app shell
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Architecture diagram
sequenceDiagram
participant User
participant Browser as Web Browser
participant Electron as Electron Shell
participant React as React App
participant Theme as Theme System
Note over User,Theme: Startup Background Flow
User->>Browser: Open app URL
Browser->>Browser: Parse index.html
Note over Browser: style="background-color: #0a0a0a"<br/>on <html> and <body>
Browser->>Browser: Render dark background immediately
Browser->>React: Load JavaScript bundle
par Electron Startup Path
User->>Electron: Launch desktop app
Electron->>Electron: Create BrowserWindow
Note over Electron: backgroundColor: "#0a0a0a"
Electron->>Electron: Show window with dark background
Electron->>React: Load renderer process
end
React->>Theme: Initialize theme system
Theme->>Theme: Apply CSS variables (bg-background, text-foreground)
alt Web Path
React->>React: Mount root component
React->>Theme: Use bg-background on app container
React->>Theme: Use bg-background on TitleBar
Note over React: TitleBar uses bg-background<br/>instead of hardcoded color
else Electron Path
React->>React: Mount root component
React->>Theme: Use bg-background on app container
React->>Theme: Use bg-background on TitleBar
Note over React: TitleBar uses bg-background
end
Note over Browser,Electron: Background color matches shared theme token #0a0a0a
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing