Add CI workflow - #44
Merged
Merged
Conversation
- Check formatting, lint, types, and tests - Build the web and desktop applications
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Architecture diagram
sequenceDiagram
participant GitHub as GitHub (Push/PR/Manual)
participant Actions as GitHub Actions CI
participant Runner as Verify Job (ubuntu-latest)
participant Repo as Repository
participant Pnpm as pnpm 11.9.0
participant Node as Node.js 24
participant Code as Codebase
Note over GitHub,Code: CI Pipeline Flow
alt Event: Push to main OR Pull request OR Manual trigger
GitHub->>Actions: Trigger workflow
end
Actions->>Actions: Set concurrency: ci-$workflow-$ref
opt If previous run in progress
Actions->>Actions: Cancel in-progress run
end
Actions->>Runner: Start verify job (timeout: 20 min)
Runner->>Repo: Check out code
Repo-->>Runner: Repository code
Runner->>Pnpm: Set up pnpm (version 11.9.0)
Pnpm-->>Runner: pnpm ready
Runner->>Node: Set up Node.js (version 24) with pnpm cache
Node-->>Runner: Node.js ready
Runner->>Pnpm: pnpm install --frozen-lockfile
Pnpm->>Code: Install dependencies from lockfile
Code-->>Pnpm: Dependencies installed
Pnpm-->>Runner: Success
Runner->>Pnpm: pnpm exec vp check
Pnpm->>Code: Formatting, lint, type check
Code-->>Pnpm: Results
Pnpm-->>Runner: Pass/fail
Runner->>Pnpm: pnpm exec vp run -r test
Pnpm->>Code: Run all tests
Code-->>Pnpm: Test results
Pnpm-->>Runner: Pass/fail
Runner->>Pnpm: pnpm --filter @showtime/web build
Pnpm->>Code: Build web app
Code-->>Pnpm: Build output
Pnpm-->>Runner: Success/failure
Runner->>Pnpm: pnpm --filter @showtime/desktop exec tsc
Pnpm->>Code: TypeScript compilation for desktop
Code-->>Pnpm: Compiled code
Pnpm-->>Runner: Success/failure
Runner->>Pnpm: pnpm --filter @showtime/desktop exec vp build --config electron.vite.config.ts
Pnpm->>Code: Build desktop app with Electron
Code-->>Pnpm: Build output
Pnpm-->>Runner: Success/failure
alt All steps succeed
Runner-->>Actions: Job passed
Actions-->>GitHub: ✅ Green check
else Any step fails
Runner-->>Actions: Job failed
Actions-->>GitHub: ❌ Red X
end
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Remove the redundant standalone web build step - Run the desktop package build command
This reverts commit 8215a92.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, pull requests, and manual runs.Testing