Skip to content

fixes #251: Override & bump testing dependencies to enable some JUnit 5 tests - #252

Merged
guusdk merged 1 commit into
igniterealtime:mainfrom
Fishbowler:junit5
Sep 9, 2026
Merged

guusdk merged 1 commit into
igniterealtime:mainfrom
Fishbowler:junit5

Conversation

@Fishbowler

@Fishbowler Fishbowler commented Sep 9, 2026 •

Copy link
Copy Markdown
Member
  • Bump the Openfire-inherited maven-surefire-plugin to enable JUnit 5 tests.
  • Override and bump transitive Jupiter for more modern JUnit 5 dependencies
  • Include JUnit Vintage to preserve JUnit 4 tests

Summary by CodeRabbit

  • Tests
    • Added support for running JUnit 5 tests.
    • Preserved compatibility with existing JUnit 4 tests.

…ble some JUnit5 tests

Bump inherited maven-surefire-plugin to enable JUnit 5 tests.
Override transitive Jupiter to run JUnit 5 tests.
Include JUnit Vintage to preserve JUnit 4 tests.
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 84390f52-b8f8-49f4-b03b-316a8105b36a

📥 Commits

Reviewing files that changed from the base of the PR and between 9bbe621 and 31007fa.

📒 Files selected for processing (1)
  • pom.xml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Maven configuration adds JUnit Jupiter and Vintage dependencies, defines their version, and configures Maven Surefire 3.6.0 for JUnit 5 execution while retaining JUnit 4 compatibility.

Changes

JUnit test execution

Layer / File(s) Summary
Configure JUnit test runtime
pom.xml
The build defines JUnit version 6.1.3, configures Maven Surefire 3.6.0, and adds test-scoped Jupiter and Vintage Engine dependencies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 31007

The build now supports JUnit 5 tests while preserving existing JUnit 4 test execution through Vintage. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating testing dependencies and Surefire configuration to enable JUnit 5 tests while retaining JUnit 4 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@guusdk
guusdk merged commit c4e0c2f into igniterealtime:main Sep 9, 2026
6 checks passed
@Fishbowler
Fishbowler deleted the junit5 branch September 9, 2026 13:47
guusdk pushed a commit that referenced this pull request Sep 9, 2026
#252 neglected to add a changelog entry representing #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants