Skip to content

OF-3365: Fix client session table - #3491

Merged
akrherz merged 1 commit into
igniterealtime:mainfrom
guusdk:OF-3365_Session-details-multiple-sessions
Sep 9, 2026
Merged

OF-3365: Fix client session table#3491
akrherz merged 1 commit into
igniterealtime:mainfrom
guusdk:OF-3365_Session-details-multiple-sessions

Conversation

@guusdk

@guusdk guusdk commented Sep 9, 2026

Copy link
Copy Markdown
Member

Fixes the rendering of data on the table below the client session details, showing all sessions for the same user.

I've also replaced the stale background-color-based legend with style-based indicator.

image

Fixes the rendering of data on the table below the client session details, showing all sessions for the same user.

I've also replaced the stale background-color-based legend with style-based indicator.
@guusdk guusdk added the backport 5.1 on merge, GHA will generate a PR with these changes against 5.1 branch label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c84e0f6c-7435-4bec-9f2b-7ef7a042e500

📥 Commits

Reviewing files that changed from the base of the PR and between 3b12d82 and 8ec5ee8.

📒 Files selected for processing (3)
  • i18n/src/main/resources/openfire_i18n.properties
  • i18n/src/main/resources/openfire_i18n_nl.properties
  • xmppserver/src/main/webapp/session-details.jsp

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The session details page now always retrieves the full session collection and derives the session count from it. It tracks the viewed session index during multiple-session rendering. The current-session legend now uses a styled span with the formatted index. English and Dutch localization files define the new session index label.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 8ec5e

The session details page now displays all sessions for a user and labels the current session with localized text. The supplied changes show no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly matches the changes. It describes fixing the client session table to show all sessions and replacing the legend styling.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akrherz
akrherz merged commit 0e3cde1 into igniterealtime:main Sep 9, 2026
43 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Successfully created backport PR for 5.1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1 on merge, GHA will generate a PR with these changes against 5.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants