OF-3326 - Default to Java 21 in Docker, add Java 25 variant - #3419
OF-3326 - Default to Java 21 in Docker, add Java 25 variant#3419Fishbowler wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Dockerfile now accepts Suggested reviewers: Merge Risk: 🟡 Moderate · up to Version tag pushes currently would omit the promised major.minor image aliases such as 5.1 and its Java variants, leaving the published tags inconsistent with the PR description. The workflow rules should be corrected before merge. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c53dc32 to
b5154ab
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/continuous-integration-workflow.yml (1)
1299-1303: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winMove the generated tags into
env. Line 1302 splices multiline step outputs directly into the shell script; pass them through environment variables first so the script only expands$PLAIN_TAGSand$VERSIONED_TAGS.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/continuous-integration-workflow.yml around lines 1299 - 1303, The tag-pushing shell step is expanding multiline step outputs directly inside the script, which should be moved into environment variables instead. Update the Tag and push image step to pass the values from steps.meta.outputs.tags and steps.meta-versioned.outputs.tags through env (for example as PLAIN_TAGS and VERSIONED_TAGS), then build ALL_TAGS from those variables inside the run block; use the existing push step to locate it.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/continuous-integration-workflow.yml:
- Around line 1285-1297: The two docker/metadata-action@v6 steps in the workflow
metadata setup need the semver minor alias added so release images publish both
full tags and minor-version tags. Update the metadata configuration in the
“Extract metadata (plain tags, default Java version only)” step and the “Extract
metadata (versioned tags)” step to include a semver rule using
pattern={{major}}.{{minor}}, and keep the existing java suffix behavior in the
meta-versioned step so it produces tags like 5.1 and 5.1-java25.
---
Nitpick comments:
In @.github/workflows/continuous-integration-workflow.yml:
- Around line 1299-1303: The tag-pushing shell step is expanding multiline step
outputs directly inside the script, which should be moved into environment
variables instead. Update the Tag and push image step to pass the values from
steps.meta.outputs.tags and steps.meta-versioned.outputs.tags through env (for
example as PLAIN_TAGS and VERSIONED_TAGS), then build ALL_TAGS from those
variables inside the run block; use the existing push step to locate it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 48c4c722-8e72-401c-b755-2c1be4d01eaf
📒 Files selected for processing (2)
.github/workflows/continuous-integration-workflow.ymlDockerfile
b5154ab to
b2fcdaf
Compare
b2fcdaf to
453deca
Compare
Java 21 is LTS, and we've got users using it. This upgrades our default container images to use it.
Changes to Java make a jump to 25 by default too risky for plugins at this point in time, but this adds a 25 variant to our publishing to allow experimentation.
This adds
-java21and-java25suffixes to image tags, and defaults the "suffixless" version to Java 21.