Repository navigation
WebUI: the first load stays on the page - #6
Merged
Merged
Conversation
…he system back from a page stops at Home
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On its first load the WebUI ran
history.back().loadPage('home')treats any move to Home from another page as "drop the entry we pushed", and on the first load the current page is empty, not Home. With no entry of its own to drop, it went back to whatever came before. A fresh browser tab went blank. The system back from a page went back twice and left the WebUI.It now goes back only when the current history entry is the one the WebUI pushed (
history.state === true).Checked in Chromium (one browser session, in order):