Repository navigation
v2.5.1: first stable release, and backups can be deleted from the phone - #1
Merged
Merged
Conversation
- FBS_CHANNEL is stable: module.prop drops (Beta), the WebUI hides its Beta chip and release.yml no longer forces a pre-release. - fbs delete <folder> removes one finished backup, only directly under Backups and never a hidden .partial- folder. The Backup tab has a Delete button with a confirmation. - Tests for delete, and the WebUI smoke test checks a stable build shows no Beta chip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable channel
FBS_CHANNEL=stable, sorelease.ymlno longer forces a pre-release.Delete a backup
fbs delete <folder>removes one finished backup..partial-folder or a path with/.Tests
tests/run.sh: 226/226 pass (sh, bash, dash). New checks cover path escape, hidden folders, missing folders and a real delete.tests/webui-smoke.shpasses. It now checks that a stable build shows no Beta chip and that the Delete button is there.