feat(auth): allow anonymous download for global skills#442
Open
myml wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the handleDownload function in skill-detail.tsx to allow users to download content without being logged in if the namespace is set to 'global'. The review feedback identifies a need for stricter type checking by using the !== operator and suggests improving code readability by adding spaces around operators, aligning with standard TypeScript practices.
|
|
||
| const handleDownload = async () => { | ||
| if (!user) { | ||
| if (namespace!='global' && !user) { |
There was a problem hiding this comment.
The comparison uses the non-strict inequality operator != and lacks spaces, which is inconsistent with the rest of the file and violates standard TypeScript idioms. Use the strict inequality operator !== and add spaces around the operator for better readability and consistency.
Suggested change
| if (namespace!='global' && !user) { | |
| if (namespace !== 'global' && !user) { |
References
- Always use === and !== instead of == and != to avoid type coercion issues and maintain consistency, as recommended by the Google TypeScript Style Guide. (link)
Update handleDownload to bypass the authentication requirement when the namespace is 'global'. This enables unauthenticated users to download public global skills, consistent with the publicly accessible route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update handleDownload to bypass the authentication requirement when the
namespace is 'global'. This enables unauthenticated users to download
public global skills, consistent with the publicly accessible route.