Skip to content

chore(cli): bump version to 0.1.6#436

Merged
dongmucat merged 1 commit into
mainfrom
cli-bump-0.1.6
May 14, 2026
Merged

chore(cli): bump version to 0.1.6#436
dongmucat merged 1 commit into
mainfrom
cli-bump-0.1.6

Conversation

@dongmucat
Copy link
Copy Markdown
Collaborator

变更

发布 CLI 0.1.6,将版本号从 0.1.5 同步到:

  • cli/package.json0.1.6
  • cli/src/generated/pkg-info.tsPKG_VERSION = "0.1.6"

说明

pkg-info.tscli/scripts/generate-pkg-info.tspackage.json 生成,本地无 bun 环境,故按生成模板手动同步,结果与脚本输出一致。

合入后,单独推 cli-v0.1.6 tag 触发 release-cli.yml 工作流执行 npm 发布与 GitHub Release。

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the package version from 0.1.5 to 0.1.6 in package.json and the generated pkg-info.ts file. The reviewer suggests using atomic pushes for version updates to ensure consistency and advises against manual edits to generated files, recommending the use of scripts or CI automation to maintain a single source of truth.

Comment thread cli/package.json
{
"name": "@astron-team/skillhub",
"version": "0.1.5",
"version": "0.1.6",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

根据项目通用规则,在进行版本号变更时,建议使用原子推送(Atomic Push)。PR 说明中提到计划在合入后单独推送标签,这可能会导致仓库在短时间内处于“有版本更新但无对应标签”的不一致状态。建议在推送版本变更时,将分支和标签合并为一个 git push 命令,或使用 git push --atomic,以确保操作的原子性。

References
  1. 在推送版本更新时,应将分支和标签合并为一个 'git push' 命令(或使用 'git push --atomic')以确保操作的原子性,防止提交与标签脱节。

// Generated by scripts/generate-pkg-info.ts - do not edit by hand.
export const PKG_NAME = "@astron-team/skillhub"
export const PKG_VERSION = "0.1.5"
export const PKG_VERSION = "0.1.6"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

该文件明确标注了“由脚本生成,请勿手动编辑”。虽然 PR 说明中解释了因本地环境缺少 Bun 而手动同步,但手动修改生成文件违背了维护单一事实来源(Single Source of Truth)的原则,且容易在未来引入人为错误。建议配置好本地 Bun 环境以运行 scripts/generate-pkg-info.ts,或者考虑通过 CI 流程自动处理此类生成文件的更新。

@dongmucat dongmucat merged commit 098616d into main May 14, 2026
7 of 9 checks passed
dongmucat added a commit that referenced this pull request May 14, 2026
The previous lockfile had all 138 dependency tarball URLs pinned to
registry.npmmirror.com (leaked from a developer's ~/.npmrc). This made
`bun install --frozen-lockfile` slow or hang on GitHub-hosted runners
located outside China — observed on macos-latest in PR #436 (stuck
9+ minutes on bun install).

Regenerated with the default registry so URLs resolve at install time
via the client-configured registry instead of being baked into the
lockfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant