Replace MD5-based file creation tests with structural output validation#12
Closed
Replace MD5-based file creation tests with structural output validation#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TestFileCreationto remove MD5 hashing and instead generate a mesh reference and perform structural checks for each output format (src/test/test_file_creation.h,src/test/test_file_creation.cpp).MeshReferencetype and per-format assertion helpers that validate: OBJv/vn/frecord counts, PLY header fields and binary payload size, and STL triangle count and expected binary size.pkg_check_modules(CRYPTO ...)andPkgConfig::CRYPTOfromsrc/test/CMakeLists.txt, and removed OpenSSL from the installation prerequisites indocs/installation.rst.<openssl/...>, MD5 helper) with standard includes (<cstdint>,<filesystem>,<string>) and clearer file-shape assertions.Testing
rgwhich returned no matches in the updated test/docs files (success).cmake -S src -B buildas an automated build check, which could not complete in this environment because Boost development components (iostreams,filesystem) were not available (configuration failed).Codex Task