fix: improve references section validation (#227, #218)#265
Open
1456055067 wants to merge 1 commit into
Open
Conversation
…s#218) Fixed false INVALID_REFERENCES_NAME error on standard nested XML references wrapper pattern. Rename MISSING_REFERENCES_SUBSECTIONS to MISSING_REFERENCES_CLASSIFICATION with a clearer error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The standard nested
<references>wrapper pattern (<references><name>References</name>containing inner Normative/Informative<references>subsections) was incorrectly triggeringINVALID_REFERENCES_NAMEon the outer wrapper.Fix
MISSING_REFERENCES_SUBSECTIONStoMISSING_REFERENCES_CLASSIFICATION. The previous message implied subsections were always required, which is not the case (e.g., a standalone8. Normative Referencesis valid).Checklist
MISSING_REFERENCES_CLASSIFICATIONerror codenpm test)node cli.jsagainst an XML file that uses the standard nested references wrapper pattern and previously triggered theINVALID_REFERENCES_NAMEerror — confirmed the false positive is resolved and the references section validates cleanlyIssues Resolved