Open
Conversation
grische
reviewed
Mar 3, 2026
Contributor
grische
left a comment
grische
left a comment
There was a problem hiding this comment.
I recommend that you rebase your commits and squash or fixup those together that should be squashed.
I'd expect two or three commits, not 6, in the end that can be merged:
| mirror_all_versions=False, | ||
| package_type_regex="(whl|zip|tar.gz)", | ||
| mirror_all_wheels=False, | ||
| args = create_arg_parser().parse_args( |
Contributor
There was a problem hiding this comment.
I'd rather have this refactoring as a separate PR, to simplify the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v26 packaging changed the behaviour of Specifier.contains():
old: Specifier(">=1.2.3").contains("1.3.0a1") = False
new: True
So let's get control over prereleases