Fix ReferenceError by removing obsolete hint refs and updating cleanu…#146
Fix ReferenceError by removing obsolete hint refs and updating cleanu…#146devanshu-puri wants to merge 6 commits into
Conversation
|
Someone is attempting to deploy a commit to the idna001's projects Team on Vercel. A member of the Team first needs to authorize it. |
idna001
left a comment
idna001
left a comment
There was a problem hiding this comment.
Hi, there is probably missing some uncommited changes
|
@idna001 let me check , will update soon |
…structure for stability
|
@idna001 all update i have updated kindly check |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a ReferenceError by removing obsolete hint-related refs from the main App component and refactoring hint functionality into a separate custom hook. The changes modernize the React rendering API and improve code organization.
- Extracts hint logic into a reusable
useHintcustom hook - Removes obsolete hint refs and state from App component that were causing runtime errors
- Updates React rendering to use the modern
createRootAPI
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/useHint.js | New custom hook containing all hint-related logic and state management |
| src/App.js | Removes obsolete hint refs and integrates useHint hook, fixes cleanup function |
| src/index.js | Updates to modern React 18 createRoot API |
| src/components/singlecard/SingleCard.js | Improves conditional rendering of card images |
| public/index.html | Updates mobile web app meta tag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Andreas V <46223359+idna001@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Andreas V <46223359+idna001@users.noreply.github.com>
idna001
left a comment
idna001
left a comment
There was a problem hiding this comment.
Not sure, if this is from merging. But in demo the feature is broken
|
Please see Preview: https://aa-memory-git-fork-devanshu-puri-fix-h-56152a-idna001s-projects.vercel.app/ |
|
Also there 5 new sonarcloud issues |
|
@idna001 can you mention the issues , i wil try to fix all that and send final request wih all fixes |
Signed-off-by: CodeKenshinDev <72023898+devanshu-puri@users.noreply.github.com>
|
@idna001 check it and update |
|
|
@idna001 I have created fixes in another branch name fix-error and everything works fine including the hint button , kindly check and update it |
|
@idna001 Everything's fine check it. |
This PR fixes a ReferenceError caused by obsolete hint refs (hintTimeoutRef, hintIntervalRef, hintLockedRef) that were still being referenced in the cleanup function of the main App component. The issue occurred because the hint logic was refactored into a separate hook (useHint), but the old refs were not removed.
Main Changes:
Removed unused hint refs from App.js.
Updated the cleanup function to remove references to the obsolete hint timers.
Ensured the hint feature now fully relies on the useHint hook for logic and state management.
Minor cleanup in App.js to improve readability and maintainability.
Benefits:
Resolves runtime errors (ReferenceError).
Improves separation of concerns between UI and hint logic.
Code is cleaner, easier to read, and maintainable.
Related Task: #142