Skip to content

fix incorrect subviews when using vector_potential in 2.5D #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glesur merged 2 commits into from
Jan 21, 2026
Merged

fix incorrect subviews when using vector_potential in 2.5D #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf3813
fix incorrect subviews when using vector_potential in 2.5D
glesur Jan 20, 2026
8cb9e63
fix linting error
glesur Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions src/fluid/constrainedTransport/enforceVectorPotentialBoundary.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,31 @@ template<typename Phys>
void ConstrainedTransport<Phys>::EnforceVectorPotentialBoundary(IdefixArray4D<real> &Vein) {
idfx::pushRegion("Emf::EnforceVectorPotentialBoundary");

auto Ax1 = Kokkos::subview(Vein, IDIR, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());
auto Ax2 = Kokkos::subview(Vein, JDIR, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());
auto Ax3 = Kokkos::subview(Vein, KDIR, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());

if(this->hydro->haveAxis) {
this->hydro->boundary->axis->RegularizeEMFs(Ax1, Ax2, Ax3);
}
IdefixArray3D<real> Ax1, Ax2, Ax3;

#ifdef ENFORCE_EMF_CONSISTENCY
#ifdef WITH_MPI
// This average the vector potential at the domain surface with immediate neighbours
// to ensure the vector potentials exactly match
#ifdef EVOLVE_VECTOR_POTENTIAL
#if DIMENSIONS == 3
Ax1 = Kokkos::subview(Vein, AX1e, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());
Ax2 = Kokkos::subview(Vein, AX2e, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());
#endif
Ax3 = Kokkos::subview(Vein, AX3e, Kokkos::ALL(), Kokkos::ALL(), Kokkos::ALL());


if(this->hydro->haveAxis) {
this->hydro->boundary->axis->RegularizeEMFs(Ax1, Ax2, Ax3);
}

#ifdef ENFORCE_EMF_CONSISTENCY
#ifdef WITH_MPI
// This average the vector potential at the domain surface with immediate neighbours
// to ensure the vector potentials exactly match

this->ExchangeAll(Ax1, Ax2, Ax3);
this->ExchangeAll(Ax1, Ax2, Ax3);
#endif
EnforceEMFBoundaryPeriodic(Ax1, Ax2, Ax3);
#endif
EnforceEMFBoundaryPeriodic(Ax1, Ax2, Ax3);
#endif
#endif // EVOLVE_VECTOR_POTENTIAL

idfx::popRegion();
}
Expand Down