Add Codex CMUX sidebar hook bridge#32
Merged
Merged
Conversation
Implement Codex hook installation, CMUX set-status application, stale key cleanup, and docs for cmux sidebar pills. Constraint: preserve existing Claude/lterm behavior and avoid cmux set-progress workspace-global updates Confidence: high Scope-risk: moderate Directive: Keep future edits limited to Codex/CMUX hook bridge, docs, and tests unless review expands scope Tested: cargo fmt --all; cargo test --all-targets --locked; cargo clippy --all-targets --locked -- -D warnings; git diff --check Not-tested: live Codex /hooks trust prompt interaction
Fix ultra-review findings by bounding hook-mode CMUX command execution, preserving stable launcher paths, normalizing malformed hooks event shapes, and using unique temp files while preserving hooks.json permissions. Constraint: Codex hook must remain fail-soft within its 5s installed timeout and preserve existing user/OMX hooks Confidence: high Scope-risk: narrow Directive: Keep future edits limited to review-loop findings unless another blocker expands scope Tested: cargo fmt --all; cargo test --all-targets --locked; cargo clippy --all-targets --locked -- -D warnings; git diff --check Not-tested: live package-manager upgrade path for installed hook command
Resolve review-loop blockers by resolving bare understatus launchers through install-time PATH, applying hook-level wall-clock budget before CMUX updates, and treating hooks.json permission-copy failures as install errors. Constraint: installed Codex hooks must not depend on hook runtime PATH and must leave stdout reserve inside the 5s Codex hook timeout Confidence: high Scope-risk: narrow Directive: Keep future edits limited to review-loop findings unless another blocker expands scope Tested: cargo fmt --all; cargo test --all-targets --locked; cargo clippy --all-targets --locked -- -D warnings; git diff --check Not-tested: live Homebrew Cellar upgrade path
Fix ultra-review findings by migrating legacy top-level hook events into the hooks object and bounding the manual cmux identify probe. Constraint: install-codex-hooks must produce a Codex-readable hooks.json while preserving unrelated keys and existing hooks Confidence: high Scope-risk: narrow Directive: Keep future edits limited to review-loop blockers unless another review expands scope Tested: cargo fmt --all; cargo test --all-targets --locked; cargo clippy --all-targets --locked -- -D warnings; git diff --check Not-tested: live malformed hooks.json migration outside unit fixtures
Fix ultra-review blocker by merging legacy top-level hook events with existing hooks-object events instead of dropping either shape during normalization. Constraint: install-codex-hooks must remain non-destructive for mixed legacy/current hooks.json layouts Confidence: high Scope-risk: narrow Directive: Keep future edits limited to review-loop blockers unless another review expands scope Tested: cargo fmt --all; cargo test --all-targets --locked; cargo clippy --all-targets --locked -- -D warnings; git diff --check Not-tested: arbitrary non-array mixed hook event shapes beyond unit fixtures
Bump Rust and npm package versions for the Codex CMUX sidebar release. Validation: node npm/verify-release.js 0.7.2 --verify-packlist Validation: cargo fmt --all -- --check Validation: cargo test --all-targets --locked Validation: cargo clippy --all-targets --locked -- -D warnings Validation: git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety
{}).set-status/clear-statusonly;set-progressis intentionally avoided.Tests
cargo fmt --allcargo test --all-targets --lockedcargo clippy --all-targets --locked -- -D warningsgit diff --check