Centralize manifest release loading#219
Merged
Merged
Conversation
Keep the command manifest as a literal-only data file while sharing the bounded no-follow AST loader across runtime, release gates, smoke checks, and tests. Deduplicate release-smoke dispatcher launch orchestration without changing scenarios. Constraint: context_guard_commands.py must remain literal-only and must not be imported or executed as code. Rejected: import context_guard_commands directly | would execute mutable manifest code and weaken the runtime trust boundary. Confidence: high Scope-risk: moderate Directive: Add future command/package fields through context_guard_commands.py and the shared literal loader, then sync plugin copies. Tested: python3 -m py_compile changed scripts/helpers; 7 targeted manifest/runtime tests; PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tests -p 'test_*.py' (737 tests); python3 scripts/prepublish_check.py --skip-tests; python3 scripts/sync_plugin_copies.py --check; git diff --check; python3 scripts/release_smoke.py --timeout 20. Not-tested: CI matrix before PR creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Add a shared bounded no-follow literal loader for context_guard_commands.py.\n- Reuse the loader in runtime dispatch, prepublish, release smoke, and tests while keeping the manifest literal-only.\n- Deduplicate release-smoke entrypoint/dispatcher launch loops.\n\n## Validation\n- python3 -m py_compile changed scripts/helpers\n- 7 targeted manifest/runtime unit tests\n- PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tests -p 'test_*.py' (737 tests)\n- python3 scripts/prepublish_check.py --skip-tests\n- python3 scripts/sync_plugin_copies.py --check\n- git diff --check\n- python3 scripts/release_smoke.py --timeout 20\n