Skip to content

Pin the SVG policy interpreter to icon-browser - #25

Merged
imanimanyara merged 2 commits into
mainfrom
docs/repoint-react-icon-browser
Nov 13, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
docs/repoint-react-icon-browser

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

React consolidation row 5.1 for js-icon-components. react-icon-browser is retired (owner, 2026-11-11) and its source lives in ichava/icon-browser's resources/js since react consolidation 3d.

  • Functional link repointed. vendor/source.json pinned the SVG policy interpreter (src/generator/svgPolicy.ts) to ichava/react-icon-browser's src/modules/svg/domain/svgPolicy.ts, so tests/vendored.test.ts compared it with a frozen sibling checkout and would never see a change. It now names ichava/icon-browser's resources/js/modules/svg/domain/svgPolicy.ts at 4583aa3 (icon-browser main), whose body is byte-identical: the pinned digest 3555ca7b… is unchanged.
  • Live docs and the issue template name icon-browser; the interpreter's preamble comment says where the body came from. CHANGELOG history is left as written.

No deprecations.

Verification

  • vitest run: 30 files, 420 passed. typecheck and lint: exit 0.
  • Proven red: a line planted in ../icon-browser/resources/js/modules/svg/domain/svgPolicy.ts fails "src/generator/svgPolicy.ts body matches ichava/icon-browser's resources/js/modules/svg/domain/svgPolicy.ts in the sibling checkout"; restored.

react-icon-browser is retired and its source lives in icon-browser's resources/js since react consolidation 3d. vendor/source.json named the retired repository, so tests/vendored.test.ts compared the interpreter with a frozen checkout. It now names ichava/icon-browser at the main commit that holds the same body (digest unchanged). The live docs and the issue template follow; CHANGELOG history is left as written.
Copilot AI balanced review requested due to automatic review settings November 13, 2026 21:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit 247aa83 into main Nov 13, 2026
8 checks passed
@imanimanyara
imanimanyara deleted the docs/repoint-react-icon-browser branch November 13, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants