Repository navigation
Pin the SVG policy interpreter to icon-browser - #25
Merged
Merged
Conversation
react-icon-browser is retired and its source lives in icon-browser's resources/js since react consolidation 3d. vendor/source.json named the retired repository, so tests/vendored.test.ts compared the interpreter with a frozen checkout. It now names ichava/icon-browser at the main commit that holds the same body (digest unchanged). The live docs and the issue template follow; CHANGELOG history is left as written.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React consolidation row 5.1 for js-icon-components. react-icon-browser is retired (owner, 2026-11-11) and its source lives in
ichava/icon-browser'sresources/jssince react consolidation 3d.vendor/source.jsonpinned the SVG policy interpreter (src/generator/svgPolicy.ts) toichava/react-icon-browser'ssrc/modules/svg/domain/svgPolicy.ts, sotests/vendored.test.tscompared it with a frozen sibling checkout and would never see a change. It now namesichava/icon-browser'sresources/js/modules/svg/domain/svgPolicy.tsat4583aa3(icon-browsermain), whose body is byte-identical: the pinned digest3555ca7b…is unchanged.No deprecations.
Verification
vitest run: 30 files, 420 passed.typecheckandlint: exit 0.../icon-browser/resources/js/modules/svg/domain/svgPolicy.tsfails "src/generator/svgPolicy.ts body matches ichava/icon-browser's resources/js/modules/svg/domain/svgPolicy.ts in the sibling checkout"; restored.