Repository navigation
Release on a version tag or on request, through the shared workflow - #117
Merged
Merged
Conversation
release.yml now holds only a version-tag push and a dispatch naming a tag, and calls simtabi/.github's go-release.yml. The app and launcher step moves to .scripts/release-launchers.sh, run as its post-release step, and reads the tag from it rather than GITHUB_REF_NAME.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owner, 2026-11-13: GitHub-based binaries only, built on a tag or on request, from a reusable workflow.
release.ymlnow holds only two triggers, a pushedv[0-9]+.[0-9]+.[0-9]+(or-*pre-release) tag andworkflow_dispatch -f tag=vX.Y.Z, and calls simtabi/.github's sharedgo-release.yml(pinned toa1dca58, Add the shared Go release workflow simtabi/.github#27). This replaces the-f confirm=release-godispatch gate and the per-repo pipeline..scripts/release-launchers.sh, run as the shared workflow'spost-release. It now reads the tag from the shared workflow instead ofGITHUB_REF_NAME, which is a branch name on a dispatched run, and hands its checksums to the shared workflow for attestation.TestReleaseRunsOnAVersionTagOrOnRequestreplacesTestReleaseRunsOnlyOnAConfirmedDispatch: it fails on any other trigger, a branch push, or a pipeline of its own (each proven red, with the test cache off).GITHUB_TOKEN. Its header comment says so now.docs/release.md,CONTRIBUTING.md,docs/installation.md, thetests.ymlcomments and the[0.1.0]CHANGELOG section are updated.Because a pushed tag now publishes, the planned v0.1.0 re-squash will start this repository's first binary release when it pushes the new
v0.1.0.Verification
.scripts/release-launchers.shrun against a local GoReleaser snapshot (ghstubbed): it uploads the zipped app, three Windows launchers andchecksums-launchers.txttov0.1.0;extra-checksums.txtlists the four assets and all four verify.go test -count=1 ./internal/cli/ ./internal/version/: pass. actionlint 1.7.12: clean onrelease.yml,release-please.yml,tests.yml. Changelog checker: correctly ordered.