Repository navigation
Name packs by lowercase slugs, and rename the icon-sets-extras set configs - #104
Merged
Merged
Conversation
…nfigs A pack name is a file name, a URL segment and a run-history key, so it is letters a-z and digits in words joined by single hyphens (config.IsSlug). The 20 icon-sets-extras.<set> configs become icon-sets-extras-<set>. The old spellings are deprecated, not removed: a dotted, capitalised or underscore-joined name in --pack, a registry, a config's name or its file name loads as the slug with a warning, and /packs/<old> redirects, until 1.0.0. A name with no slug spelling is refused. TestEveryShippedNameIsASlug reads the raw files, so the loader's leniency cannot hide a shipped dotted name; proven red by restoring icon-sets-extras.eva.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The owner asked for the old names to be removed. A dotted, capitalised, underscore- or space-joined name in --pack, a registry or a config's name is now refused with the rule and the slug to use, and /packs/<dotted> answers 404. The aliasing (CanonicalSlug, the deprecation warning, the old-file-name lookup, the redirect) is gone; none of it ever shipped. pack.schema.json carries the slug pattern on name so editors flag a bad name as it is typed; TestSchemaSlugPatternMatchesIsSlug keeps it and the loader on one pattern (proven red by widening the schema's). The rule is written up in docs/configuration.md "Naming packs" and CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.IsSlug). They are file names, URL segments, branch-name parts and run-history keys.icon-sets-extras.<set>configs (e.g.icon-sets-extras.ant-design) are renamedicon-sets-extras-<set>: file names,name,packs.jsonand the embedded copy. Every other shipped name was already a slug.--pack, a registry or a config'snameis refused with the rule and the slug to use;/packs/<dotted>answers 404.<pack>-<set>.Enforcement and docs
pack.schema.jsonputs the slugpatternonname, so an editor flags a bad name as it is typed.TestEveryShippedNameIsASlugreads the rawconfig/files and the registry (proven red withicon-sets-extras.eva);TestSchemaSlugPatternMatchesIsSlugkeeps the schema and the loader on one pattern (proven red by widening the schema's).namerow and "Adding a pack"), and CONTRIBUTING.md.Verification
make testexit 0,go vetclean,golangci-lint --new-from-rev=origin/main0 issues.Companion: ichava/icon-sets-extras#9 renames the recipe in that pack's manifest notes.