Skip to content

Name packs by lowercase slugs, and rename the icon-sets-extras set configs - #104

Merged
imanimanyara merged 2 commits into
mainfrom
fix/slug-pack-names
Nov 11, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
fix/slug-pack-names

Conversation

@imanimanyara

@imanimanyara imanimanyara commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pack names are lowercase slugs: letters a-z and digits in words joined by single hyphens (config.IsSlug). They are file names, URL segments, branch-name parts and run-history keys.
  • The 20 icon-sets-extras.<set> configs (e.g. icon-sets-extras.ant-design) are renamed icon-sets-extras-<set>: file names, name, packs.json and the embedded copy. Every other shipped name was already a slug.
  • Breaking, by request: old names are not kept. A dotted, capitalised, underscore- or space-joined name in --pack, a registry or a config's name is refused with the rule and the slug to use; /packs/<dotted> answers 404.
  • The check table's set label reads <pack>-<set>.

Enforcement and docs

  • pack.schema.json puts the slug pattern on name, so an editor flags a bad name as it is typed.
  • TestEveryShippedNameIsASlug reads the raw config/ files and the registry (proven red with icon-sets-extras.eva); TestSchemaSlugPatternMatchesIsSlug keeps the schema and the loader on one pattern (proven red by widening the schema's).
  • Written up in docs/configuration.md, "Naming packs" (linked from the name row and "Adding a pack"), and CONTRIBUTING.md.

Verification

make test exit 0, go vet clean, golangci-lint --new-from-rev=origin/main 0 issues.

Companion: ichava/icon-sets-extras#9 renames the recipe in that pack's manifest notes.

…nfigs

A pack name is a file name, a URL segment and a run-history key, so it is
letters a-z and digits in words joined by single hyphens (config.IsSlug).
The 20 icon-sets-extras.<set> configs become icon-sets-extras-<set>.

The old spellings are deprecated, not removed: a dotted, capitalised or
underscore-joined name in --pack, a registry, a config's name or its file
name loads as the slug with a warning, and /packs/<old> redirects, until
1.0.0. A name with no slug spelling is refused. TestEveryShippedNameIsASlug
reads the raw files, so the loader's leniency cannot hide a shipped
dotted name; proven red by restoring icon-sets-extras.eva.
Copilot AI balanced review requested due to automatic review settings November 11, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

The owner asked for the old names to be removed. A dotted, capitalised,
underscore- or space-joined name in --pack, a registry or a config's name
is now refused with the rule and the slug to use, and /packs/<dotted>
answers 404. The aliasing (CanonicalSlug, the deprecation warning, the
old-file-name lookup, the redirect) is gone; none of it ever shipped.

pack.schema.json carries the slug pattern on name so editors flag a bad
name as it is typed; TestSchemaSlugPatternMatchesIsSlug keeps it and the
loader on one pattern (proven red by widening the schema's). The rule is
written up in docs/configuration.md "Naming packs" and CONTRIBUTING.md.
@imanimanyara
imanimanyara merged commit 380aa3c into main Nov 11, 2026
11 checks passed
@imanimanyara
imanimanyara deleted the fix/slug-pack-names branch November 11, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants