Repository navigation
Depend on ichava/core alone - #2
Merged
Merged
Conversation
The provider extends core's IconPackServiceProvider and names its constants and component classes, so src/ imports no laranail type and composer.json requires php and ichava/core only. The type is ichava-icon-set, which core's discovery reads. CoreOnlyDependencyTest guards all three.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pack now depends on
ichava/coreand nothing else, following ichava/core#167.IconsServiceProviderextends core's newSupport\IconPackServiceProviderand declaresconstantsClass()andcomponentClass(). The base sets the same name, path, Blade component (<x-{slug}-icon>) and icon directory the old provider did, in the same order, plusconfig/{slug}.phpfor a pack that ships one.src/no longer importsSimtabi\Laranail\Package\Tools\Package,InvalidPathorInvalidPackage.requireisphpandichava/core;illuminate/supportandlaranail/package-toolsstill arrive through core.typeisichava-icon-set, the key core'sInformationService::discoverPackages()now reads throughComposer\InstalledVersions. Therepositoriesblock (core plus the fourlaranail/*) is unchanged: Composer reads it only from the root package, and CI installs core's dependencies through it.docs/installation.mdsay the pack requires onlyichava/coreand link to core's installation guide, the one place that lists the repositories, instead of restating thelaranail/*list. They no longer say the pack is on Packagist;repo.packagist.organswers 404 for every Ichava package.docs/architecture.md's "It requireslaranail/package-toolsdirectly" section is replaced by "It requiresichava/coreonly".tests/Unit/CoreOnlyDependencyTest.phpfails whenrequireholds anything beyondphpandichava/core, when the type is notichava-icon-set, or when asrc/file names aSimtabi\Laranailnamespace other than core's; it asserts at least 4src/files were inspected. Proved red locally by puttinglaranail/package-toolsback inrequire(1 failed, 2 passed), then green (3 passed).Local gates against core's
main: pest,phpstan --debug,laranail-pint --test, all green.