Skip to content

Add flag-icons' licence text as the sync writes it - #95

Merged
imanimanyara merged 1 commit into
mainfrom
chore/upstream-licence-texts
Nov 5, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/upstream-licence-texts

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Adds resources/assets/svg/licenses/flag-icons/LICENSE, flag-icons' MIT licence exactly as icon-sets-sync's licence sink writes it from the npm package (owner decision). Every sync wanted to add it and the pack never tracked it. ATTRIBUTION.md is unchanged.

Verification

  • Written by a real sync --pack icon-sets-flag --force with the binary built from icon-sets-sync 00579ad; the SVGs came out unchanged (added=0 removed=0 changed=0).
  • A second real sync immediately after this commit left the checkout with 0 changed files (git status --porcelain -uall empty), so the sync now reports no licence change. The dry run's licence line only lists what it would write (would_write=[LICENSE]), it does not diff, which is why the real run is the check.
  • pest: 59 passed, 1 skipped.

The licence sink writes licenses/flag-icons/LICENSE on every run and the
pack never tracked it.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 06:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit f17e9c3 into main Nov 5, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the chore/upstream-licence-texts branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants