Repository navigation
Add flag-icons' licence text as the sync writes it - #95
Merged
Merged
Conversation
The licence sink writes licenses/flag-icons/LICENSE on every run and the pack never tracked it.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
resources/assets/svg/licenses/flag-icons/LICENSE, flag-icons' MIT licence exactly as icon-sets-sync's licence sink writes it from the npm package (owner decision). Every sync wanted to add it and the pack never tracked it.ATTRIBUTION.mdis unchanged.Verification
sync --pack icon-sets-flag --forcewith the binary built from icon-sets-sync00579ad; the SVGs came out unchanged (added=0 removed=0 changed=0).git status --porcelain -uallempty), so the sync now reports no licence change. The dry run's licence line only lists what it would write (would_write=[LICENSE]), it does not diff, which is why the real run is the check.pest: 59 passed, 1 skipped.