Skip to content

test: pin the pack's kind through core's resolver - #90

Merged
imanimanyara merged 1 commit into
mainfrom
feat/declare-kinds-phase1
Nov 4, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
feat/declare-kinds-phase1

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

  • package.kind is already icon (flags are multicolour icons), so config.json is unchanged.
  • SvgKindTest checks the D6 keys core reads and that a sample from every folder resolves icon from package.kind through Support\KindResolver (skipped on a core without it).
  • docs/configuration.md describes the kind keys; CHANGELOG [Unreleased].

Test plan

  • Gates run locally against ichava/core dev-main (478657a, #162): pest, phpstan --debug level max, laranail-pint --test.
  • Guards proven red once: a bad items entry fails the config case; an unintended item entry fails the core resolver case.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit dbc2923 into main Nov 4, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the feat/declare-kinds-phase1 branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants