Repository navigation
ci: test against core main and guard sibling constraints - #83
Merged
Merged
Conversation
At release every ichava repository becomes one commit tagged v0.1.0, so a constraint that excludes 0.1.0 cannot resolve. SiblingConstraintsTest reads require and require-dev and fails on such a constraint, and on finding none to check.
Each job that installs dependencies aliases the siblings' main into the 0.1 line before the install, prints the commits it resolved, and restores composer.json afterwards, so the committed constraints never change and the tests read them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/Unit/SiblingConstraintsTest.phpfails on anyichava/*constraint inrequireorrequire-devthat 0.1.0 does not satisfy, and on finding no constraint to check. At release every ichava repository becomes one commit taggedv0.1.0, so 0.1.0 is the only version of any sibling.composer/semveris now a direct dev requirement, since the test imports it.ichava/core'smain. Every job that installs dependencies (Tests, Pint, PHPStan, Security Audit, Docs shape) runscomposer require "ichava/core:dev-main as 0.1.99" --no-updatefirst, prints the commit it resolved, and restorescomposer.jsonafter the install. The committed constraint does not change, and the tests read it.[Unreleased]anddocs/release.mddescribe both.Verification
vendor/bin/pest,laranail-pint --testand PHPStan pass locally against coremain(8c7b97f);SvgKindTest'skindFor()case runs instead of skipping (0 skipped).^0.1.2makesSiblingConstraintsTestfail; reverted.